Re: Review Request 30063: Patch for KAFKA-1840

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30063/#review71482 --- Ship it! Ship It! - Guozhang Wang On Feb. 1, 2015, 8:17 a.m., Ji

Re: Review Request 30063: Patch for KAFKA-1840

> On Feb. 5, 2015, 2:15 a.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/tools/MirrorMaker.scala, lines 687-689 > > > > > > Is there an expected use case for one-to-many handlers? Yes, for example some user mi

Re: Review Request 30063: Patch for KAFKA-1840

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30063/#review71132 --- core/src/main/scala/kafka/tools/MirrorMaker.scala

Re: Review Request 30063: Patch for KAFKA-1840

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30063/ --- (Updated Feb. 1, 2015, 8:17 a.m.) Review request for kafka. Bugs: KAFKA-1840

Re: Review Request 30063: Patch for KAFKA-1840

> On Feb. 1, 2015, 6:34 a.m., Gwen Shapira wrote: > > I like the idea of a message handler in MirrorMaker, but I think we can do > > better. Let me know if you think I'm taking it far beyond your original > > scope... I can add it as a follow up jira. > > > > 1. I think we need to let users pa

Re: Review Request 30063: Patch for KAFKA-1840

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30063/#review70523 --- I like the idea of a message handler in MirrorMaker, but I think we

Re: Review Request 30063: Patch for KAFKA-1840

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30063/#review70509 --- core/src/main/scala/kafka/tools/MirrorMaker.scala

Re: Review Request 30063: Patch for KAFKA-1840

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30063/#review70508 --- core/src/main/scala/kafka/tools/MirrorMaker.scala

Re: Review Request 30063: Patch for KAFKA-1840

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30063/ --- (Updated Jan. 31, 2015, 2:25 a.m.) Review request for kafka. Bugs: KAFKA-1840

Re: Review Request 30063: Patch for KAFKA-1840

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30063/ --- (Updated Jan. 20, 2015, 7:36 p.m.) Review request for kafka. Bugs: KAFKA-1840

Re: Review Request 30063: Patch for KAFKA-1840

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30063/#review68750 --- core/src/main/scala/kafka/tools/MirrorMaker.scala

Review Request 30063: Patch for KAFKA-1840

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30063/ --- Review request for kafka. Bugs: KAFKA-1840 https://issues.apache.org/jira/b