Re: Review Request 29952: Patch for kafka-1864

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29952/#review68437 --- Ship it! Ship It! - Neha Narkhede On Jan. 16, 2015, 12:52 a.m.,

Re: Review Request 29952: Patch for kafka-1864

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29952/#review68406 --- Ship it! core/src/main/scala/kafka/server/OffsetManager.scala

Re: Review Request 29952: Patch for kafka-1864

> On Jan. 16, 2015, 2:54 a.m., Gwen Shapira wrote: > > core/src/main/scala/kafka/server/OffsetManager.scala, line 77 > > > > > > I'm wondering why you chose to change defaults here and not in > > KafkaConfig? > > U

Re: Review Request 29952: Patch for kafka-1864

> On Jan. 16, 2015, 2:54 a.m., Gwen Shapira wrote: > > core/src/main/scala/kafka/server/OffsetManager.scala, line 77 > > > > > > I'm wondering why you chose to change defaults here and not in > > KafkaConfig? > > U

Re: Review Request 29952: Patch for kafka-1864

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29952/#review68395 --- core/src/main/scala/kafka/server/OffsetManager.scala

Re: Review Request 29952: Patch for kafka-1864

> On Jan. 16, 2015, 1:25 a.m., Joel Koshy wrote: > > core/src/main/scala/kafka/server/OffsetManager.scala, line 79 > > > > > > The only issue here is the problem raised in KAFKA-1867 - even though > > that should not h

Re: Review Request 29952: Patch for kafka-1864

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29952/#review68381 --- core/src/main/scala/kafka/server/OffsetManager.scala

Review Request 29952: Patch for kafka-1864

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29952/ --- Review request for kafka. Bugs: kafka-1864 https://issues.apache.org/jira/b