----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29952/#review68406 -----------------------------------------------------------
Ship it! core/src/main/scala/kafka/server/OffsetManager.scala <https://reviews.apache.org/r/29952/#comment112600> Although I think the documentation makes this clear the default should probably be conservative so this sounds reasonable. - Joel Koshy On Jan. 16, 2015, 12:52 a.m., Jun Rao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29952/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2015, 12:52 a.m.) > > > Review request for kafka. > > > Bugs: kafka-1864 > https://issues.apache.org/jira/browse/kafka-1864 > > > Repository: kafka > > > Description > ------- > > create offset topic with a larger replication factor by default > > > Diffs > ----- > > core/src/main/scala/kafka/server/KafkaApis.scala > d626b1710813648524eefa5a3df098393c3e7743 > core/src/main/scala/kafka/server/KafkaConfig.scala > 6e26c5436feb4629d17f199011f3ebb674aa767f > core/src/main/scala/kafka/server/OffsetManager.scala > 43eb2a35bb54d32c66cdb94772df657b3a104d1a > core/src/test/scala/integration/kafka/api/ProducerFailureHandlingTest.scala > 07a7beee9dec733eae943b425ae58c54f08458d8 > core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala > 4a3a5b264a021e55c39f4d7424ce04ee591503ef > > Diff: https://reviews.apache.org/r/29952/diff/ > > > Testing > ------- > > > Thanks, > > Jun Rao > >
