Re: Review Request 29756: Patch for KAFKA-1854

2015-01-12 Thread Neha Narkhede
> On Jan. 9, 2015, 6:48 p.m., Neha Narkhede wrote: > > kafka-patch-review.py, line 20 > > > > > > I got the following error on this patch > > > > nnarkhed-mn1:kafka nnarkhed$ python kafka-patch-review.py -b tr

Re: Review Request 29756: Patch for KAFKA-1854

2015-01-12 Thread Neha Narkhede
> On Jan. 9, 2015, 6:48 p.m., Neha Narkhede wrote: > > kafka-patch-review.py, line 20 > > > > > > I got the following error on this patch > > > > nnarkhed-mn1:kafka nnarkhed$ python kafka-patch-review.py -b tr

Re: Review Request 29756: Patch for KAFKA-1854

2015-01-09 Thread Jaikiran Pai
> On Jan. 9, 2015, 11:07 a.m., Manikumar Reddy O wrote: > > kafka-patch-review.py, line 96 > > > > > > Did you tested the failure senario? I did not get error message. I > > think we will get exception only after invok

Re: Review Request 29756: Patch for KAFKA-1854

2015-01-09 Thread Jaikiran Pai
> On Jan. 9, 2015, 6:48 p.m., Neha Narkhede wrote: > > kafka-patch-review.py, line 20 > > > > > > I got the following error on this patch > > > > nnarkhed-mn1:kafka nnarkhed$ python kafka-patch-review.py -b tr

Re: Review Request 29756: Patch for KAFKA-1854

2015-01-09 Thread Manikumar Reddy O
> On Jan. 9, 2015, 11:07 a.m., Manikumar Reddy O wrote: > > kafka-patch-review.py, line 96 > > > > > > Did you tested the failure senario? I did not get error message. I > > think we will get exception only after invok

Re: Review Request 29756: Patch for KAFKA-1854

2015-01-09 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29756/#review67477 --- kafka-patch-review.py

Re: Review Request 29756: Patch for KAFKA-1854

2015-01-09 Thread Jaikiran Pai
> On Jan. 9, 2015, 11:07 a.m., Manikumar Reddy O wrote: > > kafka-patch-review.py, line 96 > > > > > > Did you tested the failure senario? I did not get error message. I > > think we will get exception only after invok

Re: Review Request 29756: Patch for KAFKA-1854

2015-01-09 Thread Jaikiran Pai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29756/ --- (Updated Jan. 9, 2015, 12:47 p.m.) Review request for kafka. Bugs: KAFKA-1854

Re: Review Request 29756: Patch for KAFKA-1854

2015-01-09 Thread Jaikiran Pai
> On Jan. 9, 2015, 11:07 a.m., Manikumar Reddy O wrote: > > kafka-patch-review.py, line 96 > > > > > > Did you tested the failure senario? I did not get error message. I > > think we will get exception only after invok

Re: Review Request 29756: Patch for KAFKA-1854

2015-01-09 Thread Manikumar Reddy O
> On Jan. 9, 2015, 11:07 a.m., Manikumar Reddy O wrote: > > kafka-patch-review.py, line 96 > > > > > > Did you tested the failure senario? I did not get error message. I > > think we will get exception only after invok

Re: Review Request 29756: Patch for KAFKA-1854

2015-01-09 Thread Jaikiran Pai
> On Jan. 9, 2015, 11:07 a.m., Manikumar Reddy O wrote: > > kafka-patch-review.py, line 96 > > > > > > Did you tested the failure senario? I did not get error message. I > > think we will get exception only after invok

Re: Review Request 29756: Patch for KAFKA-1854

2015-01-09 Thread Jaikiran Pai
> On Jan. 9, 2015, 11:07 a.m., Manikumar Reddy O wrote: > > kafka-patch-review.py, line 96 > > > > > > Did you tested the failure senario? I did not get error message. I > > think we will get exception only after invok

Re: Review Request 29756: Patch for KAFKA-1854

2015-01-09 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29756/#review67414 --- kafka-patch-review.py

Re: Review Request 29756: Patch for KAFKA-1854

2015-01-09 Thread Jaikiran Pai
> On Jan. 9, 2015, 9:44 a.m., Manikumar Reddy O wrote: > > kafka-patch-review.py, line 134 > > > > > > Can we do authentication check at the beginning and fail-fast if the > > username/password is wrong. Currently it

Re: Review Request 29756: Patch for KAFKA-1854

2015-01-09 Thread Jaikiran Pai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29756/ --- (Updated Jan. 9, 2015, 10:13 a.m.) Review request for kafka. Bugs: KAFKA-1854

Re: Review Request 29756: Patch for KAFKA-1854

2015-01-09 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29756/#review67400 --- kafka-patch-review.py

Re: Review Request 29756: Patch for KAFKA-1854

2015-01-09 Thread Jaikiran Pai
> On Jan. 9, 2015, 7:52 a.m., Jaikiran Pai wrote: > > This one needs a minor change which I'm going to submit as an update Patch updated and now ready for review. - Jaikiran --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 29756: Patch for KAFKA-1854

2015-01-09 Thread Jaikiran Pai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29756/ --- (Updated Jan. 9, 2015, 8:09 a.m.) Review request for kafka. Bugs: KAFKA-1854

Re: Review Request 29756: Patch for KAFKA-1854

2015-01-08 Thread Jaikiran Pai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29756/#review67388 --- This one needs a minor change which I'm going to submit as an update

Review Request 29756: Patch for KAFKA-1854

2015-01-08 Thread Jaikiran Pai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29756/ --- Review request for kafka. Bugs: KAFKA-1854 https://issues.apache.org/jira/b