> On Jan. 9, 2015, 9:44 a.m., Manikumar Reddy O wrote: > > kafka-patch-review.py, line 134 > > <https://reviews.apache.org/r/29756/diff/2/?file=814144#file814144line134> > > > > Can we do authentication check at the beginning and fail-fast if the > > username/password is wrong. Currently it will update the review-board and > > fails at JIRA update. > > > > Is it possible to catch the exception/error, and show the message > > "Invalid JIRA username/password"
I've updated the patch to verify the JIRA login before publishing/updating the reviewboard. If the JIRA login fails, the patch submission tool now prints out the inability to login to JIRA and exits the tool. - Jaikiran ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29756/#review67400 ----------------------------------------------------------- On Jan. 9, 2015, 10:13 a.m., Jaikiran Pai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29756/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2015, 10:13 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1854 > https://issues.apache.org/jira/browse/KAFKA-1854 > > > Repository: kafka > > > Description > ------- > > KAFKA-1854 Allow JIRA username and password to be prompted in the absence of > a jira.ini file, during patch submission > > > Diffs > ----- > > kafka-patch-review.py b7f132f9d210b8648859ab8f9c89f30ec128ab38 > > Diff: https://reviews.apache.org/r/29756/diff/ > > > Testing > ------- > > > Thanks, > > Jaikiran Pai > >
