Re: Review Request 28268: Bump up default scala version from 2.10.1 to 2.10.4

2014-11-24 Thread Guozhang Wang
> On Nov. 22, 2014, 2:24 a.m., Joel Koshy wrote: > > Looks good, although the patch does not apply - can you rebase; check that > > it builds properly and then we can close this out. This is a little wired.. both you and Gwen said it does not apply but when I apply the patch (patch -p1 --dry-r

Re: Review Request 28268: Bump up default scala version from 2.10.1 to 2.10.4

2014-11-21 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28268/#review62721 --- Ship it! Looks good, although the patch does not apply - can you re

Re: Review Request 28268: Bump up default scala version from 2.10.1 to 2.10.4

2014-11-20 Thread Gwen Shapira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28268/#review62344 --- Ship it! I had an issue trying to apply on trunk. Other than that,

Re: Review Request 28268: Bump up default scala version from 2.10.1 to 2.10.4

2014-11-19 Thread Joe Stein
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28268/#review62304 --- Ship it! can you also update the README ### Running a task on a par

Review Request 28268: Bump up default scala version from 2.10.1 to 2.10.4

2014-11-19 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28268/ --- Review request for kafka. Bugs: KAFKA-1624 https://issues.apache.org/jira/b