----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28268/#review62344 -----------------------------------------------------------
Ship it! I had an issue trying to apply on trunk. Other than that, I applied the patch and managed to build "jar" and "cleanTest test" with no issues with Java8. Non-binding +1 from me :) bin/windows/kafka-run-class.bat <https://reviews.apache.org/r/28268/#comment104378> For some reason this doesn't seem to apply cleanly (failed to apply on trunk) - Gwen Shapira On Nov. 20, 2014, 12:23 a.m., Guozhang Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28268/ > ----------------------------------------------------------- > > (Updated Nov. 20, 2014, 12:23 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1624 > https://issues.apache.org/jira/browse/KAFKA-1624 > > > Repository: kafka > > > Description > ------- > > Compiles with Java 1.6/7/8 > > > Diffs > ----- > > bin/kafka-run-class.sh 36c742b67a7259fa35c3ed862f7ccc4673b69d9f > bin/windows/kafka-run-class.bat 8e9780e2eb74a35a72678715cccc5c09b151d0ba > build.gradle 11eb11355efddacf62d61690ad13b9c82a200230 > gradle.properties 5d3155fd4461438d8b2ec4faa9534cc2383d4951 > scala.gradle 6adf9af7dbbe71e68a07b387c3854d8c9ad339e0 > > Diff: https://reviews.apache.org/r/28268/diff/ > > > Testing > ------- > > > Thanks, > > Guozhang Wang > >
