Re: Review Request 28108: Patch for KAFKA-1664

2015-02-24 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28108/ --- (Updated Feb. 24, 2015, 7:02 p.m.) Review request for kafka. Bugs: KAFKA-1664

Re: Review Request 28108: Patch for KAFKA-1664

2015-02-24 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28108/#review73825 --- Ship it! Ship It! - Neha Narkhede On Jan. 29, 2015, 6:26 p.m., A

Re: Review Request 28108: Patch for KAFKA-1664

2015-01-29 Thread Ashish Singh
> On Jan. 26, 2015, 1:54 a.m., Neha Narkhede wrote: > > Sorry for the late review. Can check this in once you get a chance to > > address these review suggestions. Thanks for the review. Addressed the concerns. > On Jan. 26, 2015, 1:54 a.m., Neha Narkhede wrote: > > core/src/test/scala/unit/k

Re: Review Request 28108: Patch for KAFKA-1664

2015-01-29 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28108/ --- (Updated Jan. 29, 2015, 6:26 p.m.) Review request for kafka. Summary (updated