Re: Review Request 27684: Patch for KAFKA-1743

2014-11-17 Thread Manikumar Reddy O
> On Nov. 18, 2014, 2:49 a.m., Jun Rao wrote: > > Thanks for the patch. Got the following compilation error. > > > > :core:compileTestScala/Users/junrao/intellij/kafka/core/src/test/scala/unit/kafka/consumer/ZookeeperConsumerConnectorTest.scala:116: > > overloaded method value commitOffsets wit

Re: Review Request 27684: Patch for KAFKA-1743

2014-11-17 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27684/ --- (Updated Nov. 18, 2014, 5:29 a.m.) Review request for kafka. Bugs: KAFKA-1743

Re: Review Request 27684: Patch for KAFKA-1743

2014-11-17 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27684/#review61863 --- Thanks for the patch. Got the following compilation error. :core:co

Re: Review Request 27684: Patch for KAFKA-1743

2014-11-15 Thread Manikumar Reddy O
> On Nov. 14, 2014, 7:29 p.m., Jun Rao wrote: > > Thanks for the patch. For clarity, in ZookeeperConsumerConnector, instead > > of having the following, > > def commitOffsets(isAutoCommit: Boolean = true) > > > > could we break it into two separate methods, same as what's defined in > > Con

Re: Review Request 27684: Patch for KAFKA-1743

2014-11-15 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27684/ --- (Updated Nov. 16, 2014, 6:42 a.m.) Review request for kafka. Bugs: KAFKA-1743

Re: Review Request 27684: Patch for KAFKA-1743

2014-11-14 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27684/#review61486 --- Thanks for the patch. For clarity, in ZookeeperConsumerConnector, in

Re: Review Request 27684: Patch for KAFKA-1743

2014-11-14 Thread Manikumar Reddy O
> On Nov. 10, 2014, 7:50 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/consumer/ConsumerConnector.scala, lines 76-80 > > > > > > We will also need to change the interface in ConsumerConnector from > > > >

Re: Review Request 27684: Patch for KAFKA-1743

2014-11-14 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27684/ --- (Updated Nov. 14, 2014, 5 p.m.) Review request for kafka. Bugs: KAFKA-1743

Re: Review Request 27684: Patch for KAFKA-1743

2014-11-13 Thread Jun Rao
> On Nov. 10, 2014, 7:50 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/consumer/ConsumerConnector.scala, lines 76-80 > > > > > > We will also need to change the interface in ConsumerConnector from > > > >

Re: Review Request 27684: Patch for KAFKA-1743

2014-11-13 Thread Manikumar Reddy O
> On Nov. 10, 2014, 7:50 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/consumer/ConsumerConnector.scala, lines 76-80 > > > > > > We will also need to change the interface in ConsumerConnector from > > > >

Re: Review Request 27684: Patch for KAFKA-1743

2014-11-12 Thread Jun Rao
> On Nov. 10, 2014, 7:50 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/consumer/ConsumerConnector.scala, lines 76-80 > > > > > > We will also need to change the interface in ConsumerConnector from > > > >

Re: Review Request 27684: Patch for KAFKA-1743

2014-11-12 Thread Manikumar Reddy O
> On Nov. 10, 2014, 7:50 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/consumer/ConsumerConnector.scala, lines 76-80 > > > > > > We will also need to change the interface in ConsumerConnector from > > > >

Re: Review Request 27684: Patch for KAFKA-1743

2014-11-10 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27684/#review60652 --- Thanks for the patch. Some comments below. core/src/main/scala/kaf

Re: Review Request 27684: Patch for KAFKA-1743

2014-11-07 Thread Manikumar Reddy O
> On Nov. 7, 2014, 7:35 p.m., Gwen Shapira wrote: > > core/src/main/scala/kafka/consumer/ConsumerConnector.scala, line 73 > > > > > > I'd add a comment on why we have two interfaces here, since its > > none-obvious and

Re: Review Request 27684: Patch for KAFKA-1743

2014-11-07 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27684/ --- (Updated Nov. 8, 2014, 6:20 a.m.) Review request for kafka. Bugs: KAFKA-1743

Re: Review Request 27684: Patch for KAFKA-1743

2014-11-07 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27684/#review60375 --- core/src/main/scala/kafka/consumer/ConsumerConnector.scala

Re: Review Request 27684: Patch for KAFKA-1743

2014-11-07 Thread Gwen Shapira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27684/#review60364 --- core/src/main/scala/kafka/consumer/ConsumerConnector.scala

Review Request 27684: Patch for KAFKA-1743

2014-11-06 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27684/ --- Review request for kafka. Bugs: KAFKA-1743 https://issues.apache.org/jira/b