----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27684/#review60652 -----------------------------------------------------------
Thanks for the patch. Some comments below. core/src/main/scala/kafka/consumer/ConsumerConnector.scala <https://reviews.apache.org/r/27684/#comment102028> We will also need to change the interface in ConsumerConnector from def commitOffsets(retryOnFailure: Boolean = true) back to def commitOffsets In ZookeeperConsumerconnector, we can make the following method private def commitOffsets(retryOnFailure: Boolean = true) Another question, will scala compiler be confused with 2 methods, one w/o parenthsis and one with 1 parameter having a default? Could you try compiling the code on all scala versions? - Jun Rao On Nov. 8, 2014, 6:20 a.m., Manikumar Reddy O wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27684/ > ----------------------------------------------------------- > > (Updated Nov. 8, 2014, 6:20 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1743 > https://issues.apache.org/jira/browse/KAFKA-1743 > > > Repository: kafka > > > Description > ------- > > def commitOffsets method added to make ConsumerConnector backward compatible > > > Diffs > ----- > > core/src/main/scala/kafka/consumer/ConsumerConnector.scala > 07677c1c26768ef9c9032626180d0015f12cb0e0 > > Diff: https://reviews.apache.org/r/27684/diff/ > > > Testing > ------- > > > Thanks, > > Manikumar Reddy O > >
