Re: Review Request 26755: Patch for KAFKA-1706

2014-11-03 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26755/#review59679 --- Ship it! Minor points that I can fix on check-in. core/src/main/s

Re: Review Request 26755: Patch for KAFKA-1706

2014-10-29 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26755/ --- (Updated Oct. 29, 2014, 5:57 p.m.) Review request for kafka. Bugs: KAFKA-1706

Re: Review Request 26755: Patch for KAFKA-1706

2014-10-28 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26755/#review58831 --- Can we add a unit test as well? - Joel Koshy On Oct. 28, 2014, 1:

Re: Review Request 26755: Patch for KAFKA-1706

2014-10-27 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26755/ --- (Updated Oct. 28, 2014, 1:34 a.m.) Review request for kafka. Bugs: KAFKA-1706

Re: Review Request 26755: Patch for KAFKA-1706

2014-10-27 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26755/#review58725 --- Another thing I forgot to mention in the earlier review: we definite

Re: Review Request 26755: Patch for KAFKA-1706

2014-10-27 Thread Joel Koshy
> On Oct. 25, 2014, 7:52 a.m., Joel Koshy wrote: > > core/src/main/scala/kafka/utils/ByteBoundedBlockingQueue.scala, line 109 > > > > > > getAndDecrement(sizeFunction.get(e)) > > Jiangjie Qin wrote: > It seems get

Re: Review Request 26755: Patch for KAFKA-1706

2014-10-26 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26755/ --- (Updated Oct. 27, 2014, 6:50 a.m.) Review request for kafka. Bugs: KAFKA-1706

Re: Review Request 26755: Patch for KAFKA-1706

2014-10-26 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26755/ --- (Updated Oct. 27, 2014, 6:47 a.m.) Review request for kafka. Bugs: KAFKA-1706

Re: Review Request 26755: Patch for KAFKA-1706

2014-10-26 Thread Jiangjie Qin
> On Oct. 25, 2014, 7:52 a.m., Joel Koshy wrote: > > Joel, thanks a lot for the review! Some comments on your comments. > On Oct. 25, 2014, 7:52 a.m., Joel Koshy wrote: > > core/src/main/scala/kafka/utils/ByteBoundedBlockingQueue.scala, line 18 > >

Re: Review Request 26755: Patch for KAFKA-1706

2014-10-25 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26755/#review58497 --- core/src/main/scala/kafka/utils/ByteBoundedBlockingQueue.scala

Re: Review Request 26755: Patch for KAFKA-1706

2014-10-15 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26755/ --- (Updated Oct. 15, 2014, 4:28 p.m.) Review request for kafka. Bugs: KAFKA-1706

Re: Review Request 26755: Patch for KAFKA-1706

2014-10-15 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26755/ --- (Updated Oct. 15, 2014, 4:26 p.m.) Review request for kafka. Bugs: KAFKA-1706

Review Request 26755: Patch for KAFKA-1706

2014-10-15 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26755/ --- Review request for kafka. Bugs: KAFKA-1706 https://issues.apache.org/jira/b