----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26755/ -----------------------------------------------------------
(Updated Oct. 29, 2014, 5:57 p.m.) Review request for kafka. Bugs: KAFKA-1706 https://issues.apache.org/jira/browse/KAFKA-1706 Repository: kafka Description (updated) ------- changed arguments name correct typo. Incorporated Joel's comments. Also fixed negative queue size problem. Incorporated Joel's comments. Added unit test for ByteBoundedBlockingQueue. Fixed a bug regarding wating time. Diffs (updated) ----- core/src/main/scala/kafka/utils/ByteBoundedBlockingQueue.scala PRE-CREATION core/src/test/scala/unit/kafka/utils/ByteBoundedBlockingQueueTest.scala PRE-CREATION Diff: https://reviews.apache.org/r/26755/diff/ Testing ------- Thanks, Jiangjie Qin