Re: Review Request 26666: Patch for KAFKA-1653

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2/#review57817 --- Ship it! Ship It! - Neha Narkhede On Oct. 21, 2014, 6:58 p.m., E

Re: Review Request 26666: Patch for KAFKA-1653

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2/ --- (Updated Oct. 21, 2014, 6:58 p.m.) Review request for kafka. Bugs: KAFKA-1653

Re: Review Request 26666: Patch for KAFKA-1653

> On Oct. 21, 2014, 4:44 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala, line 111 > > > > > > I ran a quick test on the following reassignment file and it didn't > > war

Re: Review Request 26666: Patch for KAFKA-1653

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2/#review57602 --- core/src/main/scala/kafka/admin/PreferredReplicaLeaderElectionComma

Re: Review Request 26666: Patch for KAFKA-1653

> On Oct. 16, 2014, 6:10 p.m., Neha Narkhede wrote: > > Since you fixed some other tools as well, can we also fix the preferred > > replica election command where we can de-dup the partitions? This was already removing duplicates, I had it generate an exception instead since duplicates may ind

Re: Review Request 26666: Patch for KAFKA-1653

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2/ --- (Updated Oct. 16, 2014, 9:54 p.m.) Review request for kafka. Bugs: KAFKA-1653

Re: Review Request 26666: Patch for KAFKA-1653

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2/#review56958 --- Since you fixed some other tools as well, can we also fix the prefer

Review Request 26666: Patch for KAFKA-1653

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2/ --- Review request for kafka. Bugs: KAFKA-1653 https://issues.apache.org/jira/b