> On Oct. 21, 2014, 4:44 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala, line 111 > > <https://reviews.apache.org/r/26666/diff/2/?file=723448#file723448line111> > > > > I ran a quick test on the following reassignment file and it didn't > > warn me about the duplicates in 1) the replica list and 2) the partition > > itself > > > > While running this test, I think it may also be worth de-duping the > > topic list.
Actually ignore the first part of the comment above. My kafka jar was stale. It did warn me about the duplicate replica list, but not about the partition. It will be helpful to get an error if there are duplicate partitions as well as topics in the reassignment file. Realized this only while running this test example - Neha ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26666/#review57602 ----------------------------------------------------------- On Oct. 16, 2014, 9:54 p.m., Ewen Cheslack-Postava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26666/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2014, 9:54 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1653 > https://issues.apache.org/jira/browse/KAFKA-1653 > > > Repository: kafka > > > Description > ------- > > Generate error for duplicates in PreferredLeaderElectionCommand instead of > just swallowing duplicates. > > > Report which entries are duplicated for ReassignPartitionCommand since they > may be difficult to find in large reassignments. > > > Diffs > ----- > > core/src/main/scala/kafka/admin/PreferredReplicaLeaderElectionCommand.scala > c7918483c02040a7cc18d6e9edbd20a3025a3a55 > core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala > 691d69a49a240f38883d2025afaec26fd61281b5 > core/src/main/scala/kafka/admin/TopicCommand.scala > 7672c5aab4fba8c23b1bb5cd4785c332d300a3fa > core/src/main/scala/kafka/tools/StateChangeLogMerger.scala > d298e7e81acc7427c6cf4796b445966267ca54eb > > Diff: https://reviews.apache.org/r/26666/diff/ > > > Testing > ------- > > > Thanks, > > Ewen Cheslack-Postava > >
