Re: Review Request 25155: Fix KAFKA-1616

2014-09-04 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25155/ --- (Updated Sept. 4, 2014, 8:26 p.m.) Review request for kafka. Bugs: KAFKA-1616

Re: Review Request 25155: Fix KAFKA-1616

2014-09-03 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25155/#review52276 --- A few more minor comments below. core/src/main/scala/kafka/server/

Re: Review Request 25155: Fix KAFKA-1616

2014-09-03 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25155/ --- (Updated Sept. 3, 2014, 7:52 p.m.) Review request for kafka. Bugs: KAFKA-1616

Re: Review Request 25155: Fix KAFKA-1616

2014-09-03 Thread Jun Rao
> On Sept. 2, 2014, 4:51 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/server/RequestPurgatory.scala, lines 268-270 > > > > > > I thought that we only want to call purgeSatisfied if delayed.size >= > > purgeIntve

Re: Review Request 25155: Fix KAFKA-1616

2014-09-02 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25155/ --- (Updated Sept. 2, 2014, 8:22 p.m.) Review request for kafka. Bugs: KAFKA-1616

Re: Review Request 25155: Fix KAFKA-1616

2014-09-02 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25155/ --- (Updated Sept. 2, 2014, 7:57 p.m.) Review request for kafka. Bugs: KAFKA-1616

Re: Review Request 25155: Fix KAFKA-1616

2014-09-02 Thread Guozhang Wang
> On Sept. 2, 2014, 4:51 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/server/RequestPurgatory.scala, line 251 > > > > > > It's probably better to expose an api that returns the size of the > > queue, instead of

Re: Review Request 25155: Fix KAFKA-1616

2014-09-02 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25155/#review52036 --- core/src/main/scala/kafka/server/RequestPurgatory.scala

Re: Review Request 25155: Fix KAFKA-1616

2014-09-01 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25155/ --- (Updated Sept. 1, 2014, 9:41 p.m.) Review request for kafka. Bugs: KAFKA-1616

Re: Review Request 25155: Fix KAFKA-1616

2014-09-01 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25155/ --- (Updated Sept. 1, 2014, 9:40 p.m.) Review request for kafka. Bugs: KAFKA-1616

Re: Review Request 25155: Fix KAFKA-1616

2014-09-01 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25155/ --- (Updated Sept. 1, 2014, 9:38 p.m.) Review request for kafka. Bugs: KAFKA-1616

Re: Review Request 25155: Fix KAFKA-1616

2014-09-01 Thread Guozhang Wang
> On Aug. 28, 2014, 11:44 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/server/RequestPurgatory.scala, line 258 > > > > > > I am wonder if we should do two separate tests: (1) if enqueued() >= > > purgeInterval,

Re: Review Request 25155: Fix KAFKA-1616

2014-08-28 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25155/#review51850 --- core/src/main/scala/kafka/server/RequestPurgatory.scala

Re: Review Request 25155: Fix KAFKA-1616

2014-08-28 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25155/ --- (Updated Aug. 28, 2014, 5:12 p.m.) Review request for kafka. Bugs: KAFKA-1616

Review Request 25155: Fix KAFKA-1616

2014-08-28 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25155/ --- Review request for kafka. Bugs: KAFKA-1616 https://issues.apache.org/jira/b