----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25155/#review51850 -----------------------------------------------------------
core/src/main/scala/kafka/server/RequestPurgatory.scala <https://reviews.apache.org/r/25155/#comment90475> which is size => which is the size core/src/main/scala/kafka/server/RequestPurgatory.scala <https://reviews.apache.org/r/25155/#comment90474> I am wonder if we should do two separate tests: (1) if enqueued() >= purgeInterval, we purge the dealyed queue, (2) if size >= purgeInterval, we purge the watchers. - Jun Rao On Aug. 28, 2014, 5:12 p.m., Guozhang Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25155/ > ----------------------------------------------------------- > > (Updated Aug. 28, 2014, 5:12 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1616 > https://issues.apache.org/jira/browse/KAFKA-1616 > > > Repository: kafka > > > Description > ------- > > Purgatory size to be the sum of watched list sizes; delayed request to be the > expiry queue length; remove atomic integers for metrics > > > Diffs > ----- > > core/src/main/scala/kafka/server/RequestPurgatory.scala > ce06d2c381348deef8559374869fcaed923da1d1 > > Diff: https://reviews.apache.org/r/25155/diff/ > > > Testing > ------- > > > Thanks, > > Guozhang Wang > >
