Re: Review Request 24510: Patch for KAFKA-1582

2014-08-15 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24510/#review50745 --- Ship it! Ship It! - Joel Koshy On Aug. 11, 2014, 4:23 a.m., Dong

Re: Review Request 24510: Patch for KAFKA-1582

2014-08-10 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24510/#review50159 --- Ship it! Ship It! - Guozhang Wang On Aug. 11, 2014, 4:23 a.m., D

Re: Review Request 24510: Patch for KAFKA-1582

2014-08-10 Thread Dong Lin
> On Aug. 11, 2014, 12:06 a.m., Jun Rao wrote: > > system_test/utils/kafka_system_test_utils.py, lines 1121-1124 > > > > > > Does this work as expected? > > > > I tried the following test. However, the pid in

Re: Review Request 24510: Patch for KAFKA-1582

2014-08-10 Thread Dong Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24510/ --- (Updated Aug. 11, 2014, 4:23 a.m.) Review request for kafka. Bugs: KAFKA-1582

Re: Review Request 24510: Patch for KAFKA-1582

2014-08-10 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24510/#review50127 --- Thanks for the patch. Could you take a look at the following comment

Review Request 24510: Patch for KAFKA-1582

2014-08-08 Thread Dong Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24510/ --- Review request for kafka. Bugs: KAFKA-1582 https://issues.apache.org/jira/b