> On Aug. 11, 2014, 12:06 a.m., Jun Rao wrote: > > system_test/utils/kafka_system_test_utils.py, lines 1121-1124 > > <https://reviews.apache.org/r/24510/diff/1/?file=656792#file656792line1121> > > > > Does this work as expected? > > > > I tried the following test. However, the pid in the file tt is not the > > pid of the sleep process. > > > > echo $! > tt & sleep 100
Oh, you are right. "echo #!" actually outputs the pid of last started process, thus not the pid of the sleep process here. I just uploaded a new patch to fix the problem. This time I have verified that 1) system test waits for ProducerPerformance to finish, and 2) pid of the ProducerPerformance is indeed dumped to the pid file. Please review the updated patch. Thanks! - Dong ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24510/#review50127 ----------------------------------------------------------- On Aug. 11, 2014, 4:23 a.m., Dong Lin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24510/ > ----------------------------------------------------------- > > (Updated Aug. 11, 2014, 4:23 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1582 > https://issues.apache.org/jira/browse/KAFKA-1582 > > > Repository: kafka > > > Description > ------- > > KAFKA-1582; System Test should wait for producer to finish > > > Diffs > ----- > > system_test/utils/kafka_system_test_utils.py > 6edd64a92ce749421b5ab60fbea5b55e2ccbfe94 > > Diff: https://reviews.apache.org/r/24510/diff/ > > > Testing > ------- > > > Thanks, > > Dong Lin > >
