---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24480/
---
(Updated Aug. 8, 2014, 8:13 p.m.)
Review request for kafka.
Bugs: KAFKA-1578
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24480/#review50069
---
Looks good. Just a couple of minor comments below.
core/src/main/s
> On Aug. 8, 2014, 6:10 p.m., Joel Koshy wrote:
> > I don't see a diff with v1 - did you mean to update the diff to deregister
> > the broker change listener as well?
>
> Guozhang Wang wrote:
> You can clikc on "Diff r2" of the previous tab of Review request changed.
My bad actually. The R
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24480/
---
(Updated Aug. 8, 2014, 6:39 p.m.)
Review request for kafka.
Bugs: KAFKA-1578
> On Aug. 8, 2014, 6:10 p.m., Joel Koshy wrote:
> > I don't see a diff with v1 - did you mean to update the diff to deregister
> > the broker change listener as well?
You can clikc on "Diff r2" of the previous tab of Review request changed.
- Guozhang
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24480/#review50055
---
I don't see a diff with v1 - did you mean to update the diff to dere
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24480/
---
(Updated Aug. 8, 2014, 5:28 p.m.)
Review request for kafka.
Bugs: KAFKA-1578
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24480/#review50001
---
Thanks for the patch. Should we unregister the BrokerChangeListener
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24480/
---
Review request for kafka.
Bugs: KAFKA-1578
https://issues.apache.org/jira/b
