----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24480/#review50001 -----------------------------------------------------------
Thanks for the patch. Should we unregister the BrokerChangeListener in ReplicaStateMachine too? - Jun Rao On Aug. 7, 2014, 11:18 p.m., Guozhang Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24480/ > ----------------------------------------------------------- > > (Updated Aug. 7, 2014, 11:18 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1578 > https://issues.apache.org/jira/browse/KAFKA-1578 > > > Repository: kafka > > > Description > ------- > > De-register all listeners on controller designation > > > Diffs > ----- > > core/src/main/scala/kafka/controller/KafkaController.scala > a7a21df685e01b41154d52614f62d16759adeec2 > core/src/main/scala/kafka/controller/PartitionStateMachine.scala > 34c70b69dc63bcc9d04633da095f9fef1e0f0fe0 > > Diff: https://reviews.apache.org/r/24480/diff/ > > > Testing > ------- > > > Thanks, > > Guozhang Wang > >
