Re: Review Request 23705: Addressing Jun's comments

2014-07-23 Thread Guozhang Wang
> On July 21, 2014, 6:16 p.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/tools/DumpLogSegments.scala, line 165 > > > > > > Would key also be null possibly? > > Manikumar Reddy O wrote: > This line is surr

Re: Review Request 23705: Addressing Jun's comments

2014-07-23 Thread Manikumar Reddy O
> On July 21, 2014, 6:16 p.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/tools/DumpLogSegments.scala, line 165 > > > > > > Would key also be null possibly? > > Manikumar Reddy O wrote: > This line is surr

Re: Review Request 23705: Addressing Jun's comments

2014-07-23 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23705/ --- (Updated July 23, 2014, 2:55 p.m.) Review request for kafka. Bugs: KAFKA-1192

Re: Review Request 23705: Addressing Jun's comments

2014-07-22 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23705/#review48440 --- Looks good. Just one minor comment below. core/src/main/scala/kafk

Re: Review Request 23705: Addressing Jun's comments

2014-07-22 Thread Guozhang Wang
> On July 21, 2014, 6:16 p.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/tools/DumpLogSegments.scala, line 165 > > > > > > Would key also be null possibly? > > Manikumar Reddy O wrote: > This line is surr

Re: Review Request 23705: Addressing Jun's comments

2014-07-22 Thread Manikumar Reddy O
> On July 21, 2014, 6:16 p.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/tools/DumpLogSegments.scala, line 165 > > > > > > Would key also be null possibly? This line is surrounded by if(msg.hasKey) check. ms

Re: Review Request 23705: Addressing Jun's comments

2014-07-21 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23705/#review48265 --- core/src/main/scala/kafka/tools/DumpLogSegments.scala

Re: Review Request 23705: Addressing Jun's comments

2014-07-21 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23705/ --- (Updated July 21, 2014, 3:16 p.m.) Review request for kafka. Summary (updated