----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23705/#review48440 -----------------------------------------------------------
Looks good. Just one minor comment below. core/src/main/scala/kafka/tools/DumpLogSegments.scala <https://reviews.apache.org/r/23705/#comment85043> It's probably better to call this valueDecoder. - Jun Rao On July 21, 2014, 3:16 p.m., Manikumar Reddy O wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23705/ > ----------------------------------------------------------- > > (Updated July 21, 2014, 3:16 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1192 > https://issues.apache.org/jira/browse/KAFKA-1192 > > > Repository: kafka > > > Description > ------- > > Support given for custom deserialization of messages and keys > > > Diffs > ----- > > core/src/main/scala/kafka/tools/DumpLogSegments.scala > 6daf87b25a48a51aafb7dbe8d0c0371e0ea7501f > > Diff: https://reviews.apache.org/r/23705/diff/ > > > Testing > ------- > > > Thanks, > > Manikumar Reddy O > >
