Re: Review Request 23291: Patch for KAFKA-1528

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23291/ --- (Updated July 8, 2014, 7:36 p.m.) Review request for kafka. Bugs: KAFKA-1528

Re: Review Request 23291: Patch for KAFKA-1528

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23291/ --- (Updated July 8, 2014, 7:15 p.m.) Review request for kafka. Bugs: KAFKA-1528

Re: Review Request 23291: Patch for KAFKA-1528

> On July 6, 2014, 5:01 p.m., Jun Rao wrote: > > .gitattributes, lines 1-2 > > > > > > Thanks for the patch. Since we explicitly specify the text types, do we > > still need this line? > > Evgeny Vereshchagin wrote: >

Re: Review Request 23291: Patch for KAFKA-1528

> On July 6, 2014, 5:01 p.m., Jun Rao wrote: > > .gitattributes, lines 1-2 > > > > > > Thanks for the patch. Since we explicitly specify the text types, do we > > still need this line? >> * text=auto set the default be

Re: Review Request 23291: Patch for KAFKA-1528

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23291/#review47357 --- .gitattributes

Re: Review Request 23291: Patch for KAFKA-1528

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23291/ --- (Updated July 6, 2014, 4:23 p.m.) Review request for kafka. Bugs: KAFKA-1528

Review Request 23291: Patch for KAFKA-1528

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23291/ --- Review request for kafka. Bugs: KAFKA-1528 https://issues.apache.org/jira/b