> On July 6, 2014, 5:01 p.m., Jun Rao wrote: > > .gitattributes, lines 1-2 > > <https://reviews.apache.org/r/23291/diff/2/?file=624384#file624384line1> > > > > Thanks for the patch. Since we explicitly specify the text types, do we > > still need this line?
>> * text=auto set the default behavior, in case people don't have >> core.autocrlf set. >> But it means that you really trust Git to do binary detection properly Yes, you're right. I will drop this line and add other text files names (for example, HEADER, LICENCE, NOTICE etc) if you approve. - Evgeny ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23291/#review47357 ----------------------------------------------------------- On July 6, 2014, 4:23 p.m., Evgeny Vereshchagin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23291/ > ----------------------------------------------------------- > > (Updated July 6, 2014, 4:23 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1528 > https://issues.apache.org/jira/browse/KAFKA-1528 > > > Repository: kafka > > > Description > ------- > > See http://adaptivepatchwork.com/2012/03/01/mind-the-end-of-your-line/ > See https://help.github.com/articles/dealing-with-line-endings > > Normalize line endings. Contents the same. > > > Add text attribute to *.md files > > > Diffs > ----- > > .gitattributes PRE-CREATION > bin/windows/kafka-run-class.bat f4d2904a3320ae756ed4171f6e99566f1f0cf963 > bin/windows/kafka-server-stop.bat b9496ce0fe7438b9df1bbdb10bd86ddefab27ff4 > bin/windows/zookeeper-server-stop.bat > 29bdee81ac3ac4a96b081ac369d8f6d85c237747 > > Diff: https://reviews.apache.org/r/23291/diff/ > > > Testing > ------- > > > Thanks, > > Evgeny Vereshchagin > >
