Re: Review Request 22905: Patch for KAFKA-1477

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22905/ --- (Updated June 27, 2014, 4:34 p.m.) Review request for kafka. Repository: kafk

Re: Review Request 22905: Patch for KAFKA-1477

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22905/ --- (Updated June 27, 2014, 1:22 a.m.) Review request for kafka. Repository: kafk

Re: Review Request 22905: Patch for KAFKA-1477

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22905/ --- (Updated June 27, 2014, 1:20 a.m.) Review request for kafka. Repository: kafk

Re: Review Request 22905: Patch for KAFKA-1477

> On June 26, 2014, 12:51 a.m., Joel Koshy wrote: > > core/src/main/scala/kafka/api/RequestKeys.scala, line 36 > > > > > > Just wondering if TransactionMetadata is misleading - since we are > > actually inquiring about

Re: Review Request 22905: Patch for KAFKA-1477

> On June 26, 2014, 12:51 a.m., Joel Koshy wrote: > > core/src/main/scala/kafka/api/TransactionMetadataRequest.scala, line 60 > > > > > > typo in comment Excuse me.. But where is the typo? > On June 26, 2014, 12:51 a

Re: Review Request 22905: Patch for KAFKA-1477

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22905/#review46576 --- This is not terribly important since we will be moving over to the s

Review Request 22905: Patch for KAFKA-1477

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22905/ --- Review request for kafka. Bugs: KAFKA-1477 https://issues.apache.org/jira/b