----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22905/#review46576 -----------------------------------------------------------
This is not terribly important since we will be moving over to the schema definitions soon, but we can also add test cases for these requests in RequestResponseSerializationTest core/src/main/scala/kafka/api/RequestKeys.scala <https://reviews.apache.org/r/22905/#comment82031> Just wondering if TransactionMetadata is misleading - since we are actually inquiring about the transaction coordinator. That TransactionCoordinatorMetadata is a bit unwieldy though. core/src/main/scala/kafka/api/TransactionMetadataRequest.scala <https://reviews.apache.org/r/22905/#comment82249> typo in comment core/src/main/scala/kafka/api/TransactionMetadataRequest.scala <https://reviews.apache.org/r/22905/#comment82250> same here core/src/main/scala/kafka/api/TransactionRequest.scala <https://reviews.apache.org/r/22905/#comment82254> We will most likely need to incorporate a generation as well to handle the single-writer requirement. core/src/main/scala/kafka/api/TransactionRequest.scala <https://reviews.apache.org/r/22905/#comment82251> Thinking about this: wondering if we should remove this and have the broker always treat it with required acks -1 i.e., why would a producer want to have transactions and then set this to anything other than -1 core/src/main/scala/kafka/api/TransactionRequest.scala <https://reviews.apache.org/r/22905/#comment82253> Should probably append this only if details is true. - Joel Koshy On June 24, 2014, 2:02 a.m., Dong Lin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22905/ > ----------------------------------------------------------- > > (Updated June 24, 2014, 2:02 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1477 > https://issues.apache.org/jira/browse/KAFKA-1477 > > > Repository: kafka > > > Description > ------- > > Add request and response for transaction control and its metadata > > > Diffs > ----- > > core/src/main/scala/kafka/api/RequestKeys.scala > fbfc9d3aeaffed4ca85902125fcc1050086835db > core/src/main/scala/kafka/api/TransactionMetadataRequest.scala PRE-CREATION > core/src/main/scala/kafka/api/TransactionMetadataResponse.scala > PRE-CREATION > core/src/main/scala/kafka/api/TransactionRequest.scala PRE-CREATION > core/src/main/scala/kafka/api/TransactionResponse.scala PRE-CREATION > core/src/main/scala/kafka/common/ErrorMapping.scala > 5559d26ba2b96059f719754a351fa4598ca8a70b > > Diff: https://reviews.apache.org/r/22905/diff/ > > > Testing > ------- > > > Thanks, > > Dong Lin > >
