Re: Review Request 22496: Patch for KAFKA-1096

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22496/#review46809 --- Ship it! Ship It! - Neha Narkhede On June 20, 2014, 10:27 p.m.,

Re: Review Request 22496: Patch for KAFKA-1096

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22496/ --- (Updated June 20, 2014, 10:27 p.m.) Review request for kafka. Bugs: KAFKA-109

Re: Review Request 22496: Patch for KAFKA-1096

> On June 20, 2014, 8:35 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/controller/KafkaController.scala, line 878 > > > > > > On second thoughts, we also don't need this API. The controller knows > > it's e

Re: Review Request 22496: Patch for KAFKA-1096

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22496/#review46316 --- core/src/main/scala/kafka/controller/KafkaController.scala

Re: Review Request 22496: Patch for KAFKA-1096

> On June 19, 2014, 4:29 a.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/controller/KafkaController.scala, line 172 > > > > > > I think this should be removed as well. Basically, the only time the > > broker

Re: Review Request 22496: Patch for KAFKA-1096

> On June 19, 2014, 4:29 a.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/controller/KafkaController.scala, line 172 > > > > > > I think this should be removed as well. Basically, the only time the > > broker

Re: Review Request 22496: Patch for KAFKA-1096

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22496/#review46184 --- core/src/main/scala/kafka/controller/KafkaController.scala

Review Request 22496: Patch for KAFKA-1096

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22496/ --- Review request for kafka. Bugs: KAFKA-1096 https://issues.apache.org/jira/b