----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22496/#review46184 -----------------------------------------------------------
core/src/main/scala/kafka/controller/KafkaController.scala <https://reviews.apache.org/r/22496/#comment81454> I think this should be removed as well. Basically, the only time the broker needs to refresh information about the controller epoch is when it gets elected as the controller. Also, it needs to reset it to 0 or something once onControllerResignation(). - Neha Narkhede On June 12, 2014, 4:52 a.m., Sriharsha Chintalapani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22496/ > ----------------------------------------------------------- > > (Updated June 12, 2014, 4:52 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1096 > https://issues.apache.org/jira/browse/KAFKA-1096 > > > Repository: kafka > > > Description > ------- > > KAFKA-1096. An old controller coming out of long GC could update its epoch to > the latest controller's epoch. > > > Diffs > ----- > > core/src/main/scala/kafka/controller/KafkaController.scala > 8af48ab500779d3d851d25050e1308f5e7b588a6 > > Diff: https://reviews.apache.org/r/22496/diff/ > > > Testing > ------- > > > Thanks, > > Sriharsha Chintalapani > >
