Re: Review Request 22131: Patch for KAFKA-1477

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22131/#review54412 --- core/src/main/scala/kafka/utils/ZkUtils.scala

Re: Review Request 22131: Patch for KAFKA-1477

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22131/#review54285 --- core/src/main/scala/kafka/tools/ConsoleProducer.scala

Re: Review Request 22131: Patch for KAFKA-1477

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22131/ --- (Updated Sept. 23, 2014, 11:14 a.m.) Review request for kafka. Bugs: KAFKA-14

Re: Review Request 22131: Patch for KAFKA-1477

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22131/ --- (Updated Sept. 23, 2014, 11:11 a.m.) Review request for kafka. Bugs: KAFKA-14

Re: Review Request 22131: Patch for KAFKA-1477

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22131/#review54191 --- config/server.properties

Re: Review Request 22131: Patch for KAFKA-1477

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22131/ --- (Updated Sept. 18, 2014, 12:43 p.m.) Review request for kafka. Bugs: KAFKA-14

Re: Review Request 22131: Patch for KAFKA-1477

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22131/#review44927 --- config/server.properties

Re: Review Request 22131: Patch for KAFKA-1477

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22131/#review44920 --- core/src/main/scala/kafka/network/security/SSLSocketChannel.scala <

Re: Review Request 22131: Patch for KAFKA-1477

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22131/#review44916 --- Ship it! Looks like the changes we did on this commit https://gith

Re: Review Request 22131: Patch for KAFKA-1477

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22131/#review44914 --- Ship it! Looks like the changes we did on this commit https://gith

Re: Review Request 22131: Patch for KAFKA-1477

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22131/#review44855 --- Looks like change to UpdateOffsetsInZK.scala (https://github.com/re

Re: Review Request 22131: Patch for KAFKA-1477

> On June 3, 2014, 12:37 p.m., Joe Stein wrote: > > core/src/main/scala/kafka/network/BlockingChannel.scala, line 80 > > > > > > ok, then can you make that log line info instead of debug please. > > thanks! never min

Re: Review Request 22131: Patch for KAFKA-1477

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22131/#review44618 --- core/src/main/scala/kafka/network/BlockingChannel.scala

Re: Review Request 22131: Patch for KAFKA-1477

> On June 3, 2014, 3:14 a.m., Joe Stein wrote: > > core/src/main/scala/kafka/network/BlockingChannel.scala, line 80 > > > > > > is this change and the ones below it, are they really required? Yes. Otherwise, there will

Re: Review Request 22131: Patch for KAFKA-1477

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22131/ --- (Updated June 3, 2014, 10:53 a.m.) Review request for kafka. Bugs: KAFKA-1477

Re: Review Request 22131: Patch for KAFKA-1477

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22131/#review44595 --- gradle/wrapper/gradle-wrapper.properties

Re: Review Request 22131: Patch for KAFKA-1477

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22131/#review44594 --- core/src/main/scala/kafka/network/security/KeyStores.scala

Re: Review Request 22131: Patch for KAFKA-1477

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22131/#review44593 --- core/src/main/scala/kafka/network/security/AuthConfig.scala

Re: Review Request 22131: Patch for KAFKA-1477

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22131/#review44592 --- core/src/main/scala/kafka/network/SocketServer.scala

Re: Review Request 22131: Patch for KAFKA-1477

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22131/#review44591 --- core/src/main/scala/kafka/network/BlockingChannel.scala

Re: Review Request 22131: Patch for KAFKA-1477

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22131/#review44590 --- core/src/main/scala/kafka/network/BlockingChannel.scala

Re: Review Request 22131: Patch for KAFKA-1477

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22131/#review44589 --- core/src/main/scala/kafka/consumer/SimpleConsumer.scala

Re: Review Request 22131: Patch for KAFKA-1477

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22131/#review44588 --- core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala

Re: Review Request 22131: Patch for KAFKA-1477

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22131/#review44587 --- core/src/main/scala/kafka/common/UnknownKeyStoreException.scala

Re: Review Request 22131: Patch for KAFKA-1477

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22131/#review44586 --- config/server.properties

Re: Review Request 22131: Patch for KAFKA-1477

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22131/#review44585 --- core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala

Re: Review Request 22131: Patch for KAFKA-1477

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22131/ --- (Updated June 2, 2014, 2:32 p.m.) Review request for kafka. Bugs: KAFKA-1477

Re: Review Request 22131: Patch for KAFKA-1477

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22131/ --- (Updated June 2, 2014, 2:07 p.m.) Review request for kafka. Bugs: KAFKA-1477

Review Request 22131: Patch for KAFKA-1477

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22131/ --- Review request for kafka. Bugs: KAFKA-1477 https://issues.apache.org/jira/b