----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22131/#review54191 -----------------------------------------------------------
config/server.properties <https://reviews.apache.org/r/22131/#comment94187> Can we set secure property to ***false*** to make kafka run in non-secure mode by default so it won't impact existing users - Rajasekar Elango On Sept. 18, 2014, 12:43 p.m., Ivan Lyutov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22131/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2014, 12:43 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1477 > https://issues.apache.org/jira/browse/KAFKA-1477 > > > Repository: kafka > > > Description > ------- > > Minor fixes, cleanup > > Refactoring > > Fixed tests compilation error. > > Updated according to requested changes: refactoring, minor edits. > > > Added basic functionality for new producer. > > > bug fixes after rebase > > > bug fix after rebase > > > Diffs > ----- > > clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java > f58b8508d3f813a51015abed772c704390887d7e > clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java > f9de4af426449cceca12a8de9a9f54a6241d28d8 > > clients/src/main/java/org/apache/kafka/clients/producer/internals/SSLSocketChannel.java > PRE-CREATION > > clients/src/main/java/org/apache/kafka/common/errors/UnknownKeyStoreException.java > PRE-CREATION > clients/src/main/java/org/apache/kafka/common/network/Selector.java > 4dd2cdf773f7eb01a93d7f994383088960303dfc > > clients/src/main/java/org/apache/kafka/common/network/security/AuthConfig.java > PRE-CREATION > > clients/src/main/java/org/apache/kafka/common/network/security/KeyStores.java > PRE-CREATION > > clients/src/main/java/org/apache/kafka/common/network/security/SecureAuth.java > PRE-CREATION > > clients/src/main/java/org/apache/kafka/common/network/security/StoreInitializer.java > PRE-CREATION > > clients/src/main/java/org/apache/kafka/common/network/security/store/JKSInitializer.java > PRE-CREATION > clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java > 5c5e3d40819e41cab7b52a0eeaee5f2e7317b7b3 > config/client.keystore PRE-CREATION > config/client.public-key PRE-CREATION > config/client.security.properties PRE-CREATION > config/consumer.properties 83847de30d10b6e78bb8de28e0bb925d7c0e6ca2 > config/producer.properties 39d65d7c6c21f4fccd7af89be6ca12a088d5dd98 > config/server.keystore PRE-CREATION > config/server.properties 5c0905a572b1f0d8b07bfca967a09cb856a6b09f > config/server.public-key PRE-CREATION > config/server.security.properties PRE-CREATION > core/src/main/scala/kafka/api/FetchRequest.scala > 51cdccf7f90eb530cc62b094ed822b8469d50b12 > core/src/main/scala/kafka/client/ClientUtils.scala > ce7ede3f6d60e756e252257bd8c6fedc21f21e1c > core/src/main/scala/kafka/cluster/Broker.scala > 9407ed21fbbd57edeecd888edc32bea6a05d95b3 > core/src/main/scala/kafka/common/UnknownKeyStoreException.scala > PRE-CREATION > core/src/main/scala/kafka/consumer/ConsumerConfig.scala > 9ebbee6c16dc83767297c729d2d74ebbd063a993 > core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala > b9e2bea7b442a19bcebd1b350d39541a8c9dd068 > core/src/main/scala/kafka/consumer/SimpleConsumer.scala > 8db9203d164a4a54f94d8d289e070a0f61e03ff9 > core/src/main/scala/kafka/controller/ControllerChannelManager.scala > ecbfa0f328ba6a652a758ab20cacef324a8b2fb8 > core/src/main/scala/kafka/network/BlockingChannel.scala > eb7bb14d94cb3648c06d4de36a3b34aacbde4556 > core/src/main/scala/kafka/network/SocketServer.scala > d67899080c21e0b6db84657d6845c7ef23b59b0e > core/src/main/scala/kafka/network/security/AuthConfig.scala PRE-CREATION > core/src/main/scala/kafka/network/security/KeyStores.scala PRE-CREATION > core/src/main/scala/kafka/network/security/SSLSocketChannel.scala > PRE-CREATION > core/src/main/scala/kafka/network/security/SecureAuth.scala PRE-CREATION > core/src/main/scala/kafka/network/security/store/JKSInitializer.scala > PRE-CREATION > core/src/main/scala/kafka/producer/ProducerConfig.scala > 3cdf23dce3407f1770b9c6543e3a8ae8ab3ff255 > core/src/main/scala/kafka/producer/ProducerPool.scala > 43df70bb461dd3e385e6b20396adef3c4016a3fc > core/src/main/scala/kafka/producer/SyncProducer.scala > 489f0077512d9a69be81649c490274964290fa40 > core/src/main/scala/kafka/producer/SyncProducerConfig.scala > 69b2d0c11bb1412ce76d566f285333c806be301a > core/src/main/scala/kafka/server/AbstractFetcherThread.scala > 2e9532e820b5b5c63dfd55f5454b32866d084a37 > core/src/main/scala/kafka/server/KafkaConfig.scala > dce48db175d6ea379f848a7768de0b1c8e4b929f > core/src/main/scala/kafka/server/KafkaHealthcheck.scala > 4acdd70fe9c1ee78d6510741006c2ece65450671 > core/src/main/scala/kafka/server/KafkaServer.scala > 28711182aaa70eaa623de858bc063cb2613b2a4d > core/src/main/scala/kafka/tools/ConsoleConsumer.scala > 323fc8566d974acc4e5c7d7c2a065794f3b5df4a > core/src/main/scala/kafka/tools/ConsoleProducer.scala > da4dad405c8d8f26a64cda78a292e1f5bfbdcc22 > core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala > d1e7c434e77859d746b8dc68dd5d5a3740425e79 > core/src/main/scala/kafka/tools/GetOffsetShell.scala > 9c6064e201eebbcd5b276a0dedd02937439edc94 > core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala > af4783646803e58714770c21f8c3352370f26854 > core/src/main/scala/kafka/tools/SimpleConsumerShell.scala > 36314f412a8281aece2789fd2b74a106b82c57d2 > core/src/main/scala/kafka/utils/ZkUtils.scala > a7b1fdcb50d5cf930352d37e39cb4fc9a080cb12 > core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala > 1bf2667f47853585bc33ffb3e28256ec5f24ae84 > core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala > 35dc071b1056e775326981573c9618d8046e601d > core/src/test/scala/unit/kafka/network/SocketServerTest.scala > 3b83a86a773147c9b29b4d271aee480efec748ad > core/src/test/scala/unit/kafka/utils/TestUtils.scala > c4e13c5240c8303853d08cc3b40088f8c7dae460 > gradle/wrapper/gradle-wrapper.jar a7634b071cb255e91a4572934e55b8cd8877b3e4 > gradlew c312b910b570f46f0435302cda44295d8903c573 > gradlew.bat 84974e20d1bef7ff9ef43933c913252189315458 > > Diff: https://reviews.apache.org/r/22131/diff/ > > > Testing > ------- > > > Thanks, > > Ivan Lyutov > >
