Re: Review Request 20616: Fix KAFKA-1409: Address Jun's comments round two

2014-04-24 Thread Guozhang Wang
> On April 24, 2014, 12:44 a.m., Jun Rao wrote: > > core/src/main/scala/kafka/log/Log.scala, lines 275-276 > > > > > > We probably should use validMessages here. I actually thought about this. The thing is that the by

Re: Review Request 20616: Fix KAFKA-1409: Address Jun's comments round two

2014-04-23 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20616/#review41250 --- core/src/main/scala/kafka/log/Log.scala

Re: Review Request 20616: Fix KAFKA-1409: Address Jun's comments round two

2014-04-23 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20616/ --- (Updated April 23, 2014, 10:20 p.m.) Review request for kafka. Summary (updat