Re: Review Request 20541: Patch for KAFKA-1411

2014-04-24 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20541/#review41417 --- Ship it! Ship It! - Neha Narkhede On April 21, 2014, 11:34 p.m.,

Re: Review Request 20541: Patch for KAFKA-1411

2014-04-22 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20541/#review41060 --- Ship it! Ship It! - Guozhang Wang On April 21, 2014, 11:34 p.m.,

Re: Review Request 20541: Patch for KAFKA-1411

2014-04-22 Thread Jun Rao
> On April 22, 2014, 12:09 a.m., Guozhang Wang wrote: > > core/src/test/scala/unit/kafka/integration/PrimitiveApiTest.scala, line 97 > > > > > > codec should be "1" The old producer supports both "1" and "gizp". - Ju

Re: Review Request 20541: Patch for KAFKA-1411

2014-04-21 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20541/#review40981 --- core/src/test/scala/unit/kafka/integration/PrimitiveApiTest.scala <

Review Request 20541: Patch for KAFKA-1411

2014-04-21 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20541/ --- Review request for kafka. Bugs: KAFKA-1411 https://issues.apache.org/jira/b