Re: Review Request 20376: Publish source jars and javadoc

2014-04-18 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20376/#review40791 --- Ship it! Ship It! - Jun Rao On April 15, 2014, 7:39 p.m., Joel K

Re: Review Request 20376: Publish source jars and javadoc

2014-04-18 Thread Joel Koshy
> On April 18, 2014, 4:54 p.m., Jun Rao wrote: > > README.md, lines 10-11 > > > > > > Do we need the trailing ###? Will make that change. > On April 18, 2014, 4:54 p.m., Jun Rao wrote: > > build.gradle, lines 78-79

Re: Review Request 20376: Publish source jars and javadoc

2014-04-18 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20376/#review40777 --- Looks good. Just some minor comments below. README.md

Re: Review Request 20376: Publish source jars and javadoc

2014-04-15 Thread Joel Koshy
> On April 16, 2014, 2:35 a.m., Joe Stein wrote: > > build.gradle, line 325 > > > > > > curious why you removed these? do they get included from another path? These were moved above (to ~ line 70) under subprojects.

Re: Review Request 20376: Publish source jars and javadoc

2014-04-15 Thread Joe Stein
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20376/#review40490 --- build.gradle

Review Request 20376: Publish source jars and javadoc

2014-04-15 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20376/ --- Review request for kafka. Bugs: KAFKA-1362 https://issues.apache.org/jira/b