Re: Review Request 20050: Fix KAFKA-1359: revert to 1st patch, plus some minor changes; unit test passed

2014-04-16 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20050/ --- (Updated April 16, 2014, 4:54 p.m.) Review request for kafka. Summary (update

Re: Review Request 20050: Fix KAFKA-1359: incorporate Jun's comments

2014-04-15 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20050/#review40433 --- The first question is whether we should we centralize all the metric

Re: Review Request 20050: Fix KAFKA-1359: incorporate Jun's comments

2014-04-11 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20050/ --- (Updated April 11, 2014, 9:20 p.m.) Review request for kafka. Summary (update

Re: Review Request 20050: Fix KAFKA-1359: move producer metrics into a centalized class; fix some bugs in SenderTest

2014-04-10 Thread Guozhang Wang
> On April 10, 2014, 11:58 p.m., Jun Rao wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java, > > lines 799-803 > > > > > > Could we register this in ProducerMetrics too? We could

Re: Review Request 20050: Fix KAFKA-1359: move producer metrics into a centalized class; fix some bugs in SenderTest

2014-04-10 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20050/#review40106 --- clients/src/main/java/org/apache/kafka/clients/producer/internals/S

Re: Review Request 20050: Fix KAFKA-1359: move producer metrics into a centalized class; fix some bugs in SenderTest

2014-04-10 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20050/ --- (Updated April 10, 2014, 5:11 p.m.) Review request for kafka. Summary (update

Re: Review Request 20050: Fix KAFKA-1359

2014-04-08 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20050/#review39836 --- clients/src/main/java/org/apache/kafka/clients/producer/internals/S

Re: Review Request 20050: Fix KAFKA-1359

2014-04-08 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20050/#review39825 --- clients/src/main/java/org/apache/kafka/clients/producer/internals/S

Re: Review Request 20050: Fix KAFKA-1359

2014-04-04 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20050/#review39598 --- clients/src/main/java/org/apache/kafka/clients/producer/internals/S

Review Request 20050: Fix KAFKA-1359

2014-04-04 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20050/ --- Review request for kafka. Bugs: KAFKA-1359 https://issues.apache.org/jira/b