Re: Review Request 19132: Patch for KAFKA-1302

2014-03-13 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19132/#review37091 --- Ship it! I'm +1 with that one minor comment I gave... - Jay Kreps

Re: Review Request 19132: Patch for KAFKA-1302

2014-03-13 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19132/#review37088 --- clients/src/main/java/org/apache/kafka/clients/producer/internals/S

Re: Review Request 19132: Patch for KAFKA-1302

2014-03-13 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19132/#review37078 --- Ship it! Minor comment below clients/src/main/java/org/apache/kaf

Re: Review Request 19132: Patch for KAFKA-1302

2014-03-13 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19132/ --- (Updated March 13, 2014, 6 p.m.) Review request for kafka. Bugs: KAFKA-1302

Re: Review Request 19132: Patch for KAFKA-1302

2014-03-13 Thread Jun Rao
> On March 12, 2014, 10:05 p.m., Guozhang Wang wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java, > > line 368 > > > > > > Would suggest to add similar logging here, e.g.: > >

Re: Review Request 19132: Patch for KAFKA-1302

2014-03-13 Thread Jun Rao
> On March 12, 2014, 6:19 p.m., Jay Kreps wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java, > > line 236 > > > > > > Jun, the way this works is intentional and I do not agree with

Re: Review Request 19132: Patch for KAFKA-1302

2014-03-12 Thread Jun Rao
> On March 12, 2014, 6:19 p.m., Jay Kreps wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java, > > line 236 > > > > > > Jun, the way this works is intentional and I do not agree with

Re: Review Request 19132: Patch for KAFKA-1302

2014-03-12 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19132/#review37002 --- clients/src/main/java/org/apache/kafka/clients/producer/internals/S

Re: Review Request 19132: Patch for KAFKA-1302

2014-03-12 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19132/#review36946 --- clients/src/main/java/org/apache/kafka/clients/producer/KafkaProduc

Review Request 19132: Patch for KAFKA-1302

2014-03-12 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19132/ --- Review request for kafka. Bugs: KAFKA-1302 https://issues.apache.org/jira/b