----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19132/#review37078 -----------------------------------------------------------
Ship it! Minor comment below clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java <https://reviews.apache.org/r/19132/#comment68366> Can we change this to "due to disconnected socket to node {}"? Understand that the node information is logged above, but logging it here makes it more readable all by itself. - Neha Narkhede On March 13, 2014, 6 p.m., Jun Rao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19132/ > ----------------------------------------------------------- > > (Updated March 13, 2014, 6 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1302 > https://issues.apache.org/jira/browse/KAFKA-1302 > > > Repository: kafka > > > Description > ------- > > address review comments. > > > Diffs > ----- > > > clients/src/main/java/org/apache/kafka/clients/producer/internals/ErrorLoggingCallback.java > PRE-CREATION > > clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java > 7b5d144f0c72319d73d0127b8911b48117e8516c > clients/src/main/java/org/apache/kafka/common/protocol/types/Struct.java > 73ad6cdb465ed885131be21c8ba1ca1494d787f9 > clients/src/main/java/org/apache/kafka/common/requests/ProduceResponse.java > 6ac2e53124d0fb9e2776a1389f097daefbad261e > core/src/main/scala/kafka/tools/newproducer/MirrorMaker.scala > d1dc13b6a3c6366b0682ef90e0be40a73d81bc4d > core/src/main/scala/kafka/utils/Utils.scala > 33e05f00d0a23d6dfec132ad0b6e45bde3960d5d > perf/src/main/scala/kafka/perf/ProducerPerformance.scala > f061dbabb49044f8fe94b8fd7dc0153c33bedeee > > Diff: https://reviews.apache.org/r/19132/diff/ > > > Testing > ------- > > > Thanks, > > Jun Rao > >
