Re: Review Request 18712: Patch for KAFKA-1281

2014-03-06 Thread Neha Narkhede
> On March 6, 2014, 9 p.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/producer/ConsoleProducer.scala, line 308 > > > > > > What about wrap producer configs in propertyOpt to read from a file, > > like ReplayL

Re: Review Request 18712: Patch for KAFKA-1281

2014-03-06 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18712/#review36425 --- Ship it! core/src/main/scala/kafka/producer/ConsoleProducer.scala

Re: Review Request 18712: Patch for KAFKA-1281

2014-03-06 Thread Neha Narkhede
> On March 6, 2014, 6:47 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/producer/ConsoleProducer.scala, lines 115-126 > > > > > > Perhaps we just need to keep one of the two options and set different > > propertie

Re: Review Request 18712: Patch for KAFKA-1281

2014-03-06 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18712/#review36390 --- Ship it! core/src/main/scala/kafka/producer/ConsoleProducer.scala

Re: Review Request 18712: Patch for KAFKA-1281

2014-03-05 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18712/ --- (Updated March 6, 2014, 12:32 a.m.) Review request for kafka. Bugs: KAFKA-128

Re: Review Request 18712: Patch for KAFKA-1281

2014-03-05 Thread Neha Narkhede
> On March 4, 2014, 7:29 p.m., Jun Rao wrote: > > core/src/test/scala/other/kafka/TestEndToEndLatency.scala, lines 59-60 > > > > > > We need to call get() on the returned future object. - Neha --

Re: Review Request 18712: Patch for KAFKA-1281

2014-03-05 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18712/ --- (Updated March 5, 2014, 11:59 p.m.) Review request for kafka. Bugs: KAFKA-128

Re: Review Request 18712: Patch for KAFKA-1281

2014-03-05 Thread Jun Rao
> On March 4, 2014, 7:29 p.m., Jun Rao wrote: > > Got the following warning when running console-producer with --new-producer. > > > > [2014-03-04 11:25:24,007] WARN The configuration > > topic.metadata.refresh.interval.ms = 500 was supplied but isn't a known > > config. (org.apache.kafka.clie

Re: Review Request 18712: Patch for KAFKA-1281

2014-03-04 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18712/#review36141 --- Got the following warning when running console-producer with --new-p

Re: Review Request 18712: Patch for KAFKA-1281

2014-03-04 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18712/ --- (Updated March 4, 2014, 6:48 p.m.) Review request for kafka. Bugs: KAFKA-1281

Re: Review Request 18712: Patch for KAFKA-1281

2014-03-04 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18712/ --- (Updated March 4, 2014, 6:47 p.m.) Review request for kafka. Bugs: KAFKA-1281

Re: Review Request 18712: Patch for KAFKA-1281

2014-03-03 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18712/ --- (Updated March 3, 2014, 11:22 p.m.) Review request for kafka. Bugs: KAFKA-128

Review Request 18712: Patch for KAFKA-1281

2014-03-03 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18712/ --- Review request for kafka. Bugs: KAFKA-1281 https://issues.apache.org/jira/b