----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18712/#review36141 -----------------------------------------------------------
Got the following warning when running console-producer with --new-producer. [2014-03-04 11:25:24,007] WARN The configuration topic.metadata.refresh.interval.ms = 500 was supplied but isn't a known config. (org.apache.kafka.clients.producer.ProducerConfig) [2014-03-04 11:25:24,008] WARN The configuration compression.codec = null was supplied but isn't a known config. (org.apache.kafka.clients.producer.ProducerConfig) core/src/main/scala/kafka/producer/ConsoleProducer.scala <https://reviews.apache.org/r/18712/#comment67058> We probably don't need to distinguish btw sending with and w/o key. By default, if the key is provided, the producer already picks a partition based on the hash of the key. core/src/main/scala/kafka/producer/ConsoleProducer.scala <https://reviews.apache.org/r/18712/#comment67059> If we are sending in sync mode, we need to call get() on the returned future object. core/src/main/scala/kafka/tools/ReplayLogProducer.scala <https://reviews.apache.org/r/18712/#comment67061> This probably needs to stay and we need to call get() on the returned future object during send() if in sync mode. core/src/main/scala/kafka/tools/ReplayLogProducer.scala <https://reviews.apache.org/r/18712/#comment67060> Do we need to provide the partition #? The target cluster may not have the same # partitions as that in the source cluster. core/src/test/scala/other/kafka/TestEndToEndLatency.scala <https://reviews.apache.org/r/18712/#comment67062> We need to call get() on the returned future object. - Jun Rao On March 4, 2014, 6:48 p.m., Neha Narkhede wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18712/ > ----------------------------------------------------------- > > (Updated March 4, 2014, 6:48 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1281 > https://issues.apache.org/jira/browse/KAFKA-1281 > > > Repository: kafka > > > Description > ------- > > > Found a few problems with the current tools. 1) Moved TestLogCleaning and > TestEndToEndLatency to under tools so we can run those using > bin/kafka-run-class.sh 2) TestLogCleaning seems to hang while sending data > using the new producer. Will file a JIRA to track this > > > First pass at refactoring tools to use the new producer. As per agreement on > KAFKA-1281, only ConsoleProducer and ProducerPerformance have the option of > using the 2 producers. Rest are converted over to use the new producer. > KafkaLog4jAppender needs an overhaul, I think. For this patch, I've just > converted it to use the new producer and deleted configs that only make sense > for the old producer. > > > Diffs > ----- > > core/src/main/scala/kafka/producer/ConsoleProducer.scala > 28de57304db6a7c79c4c75de155f6389144eb5a5 > core/src/main/scala/kafka/producer/KafkaLog4jAppender.scala > 42239b27ab26725141f4bf525d2d69538979dd44 > core/src/main/scala/kafka/tools/ReplayLogProducer.scala > 814d61ae477cef5e56723e1f1a86c3b2e9b7c1ea > core/src/main/scala/kafka/utils/CommandLineUtils.scala > 726c30257dcb55b8989163dab3bfc6888dd5d931 > core/src/test/scala/other/kafka/TestEndToEndLatency.scala > f5d39dd71ad25b0d9955d4b9bcdb56ba705abff0 > core/src/test/scala/other/kafka/TestLogCleaning.scala > 22b16e54980e30f60dbf2fbe46c16398d654ba21 > > Diff: https://reviews.apache.org/r/18712/diff/ > > > Testing > ------- > > > Thanks, > > Neha Narkhede > >
