Re: Review Request 17836: Better error message for underflow during struct deserialization

2014-02-07 Thread Neha Narkhede
> On Feb. 7, 2014, 4:29 a.m., Neha Narkhede wrote: > > clients/src/main/java/org/apache/kafka/common/protocol/types/Schema.java, > > line 53 > > > > > > This will state the field correctly. One other outstanding issue

Re: Review Request 17836: Better error message for underflow during struct deserialization

2014-02-07 Thread Jay Kreps
> On Feb. 7, 2014, 4:29 a.m., Neha Narkhede wrote: > > clients/src/main/java/org/apache/kafka/common/protocol/types/Schema.java, > > line 52 > > > > > > Does it make sense to catch all Throwables so we get meaningful e

Re: Review Request 17836: Better error message for underflow during struct deserialization

2014-02-06 Thread Neha Narkhede
> On Feb. 7, 2014, 4:29 a.m., Neha Narkhede wrote: > > clients/src/main/java/org/apache/kafka/common/protocol/types/Schema.java, > > line 52 > > > > > > Does it make sense to catch all Throwables so we get meaningful e

Re: Review Request 17836: Better error message for underflow during struct deserialization

2014-02-06 Thread Jay Kreps
> On Feb. 7, 2014, 4:29 a.m., Neha Narkhede wrote: > > clients/src/main/java/org/apache/kafka/common/protocol/types/Schema.java, > > line 52 > > > > > > Does it make sense to catch all Throwables so we get meaningful e

Re: Review Request 17836: Better error message for underflow during struct deserialization

2014-02-06 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17836/#review33898 --- clients/src/main/java/org/apache/kafka/common/protocol/types/Schema

Review Request 17836: Better error message for underflow during struct deserialization

2014-02-06 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17836/ --- Review request for kafka. Bugs: KAFKA-1241 https://issues.apache.org/jira/b