----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17836/#review33898 -----------------------------------------------------------
clients/src/main/java/org/apache/kafka/common/protocol/types/Schema.java <https://reviews.apache.org/r/17836/#comment63613> Does it make sense to catch all Throwables so we get meaningful error message in all cases? clients/src/main/java/org/apache/kafka/common/protocol/types/Schema.java <https://reviews.apache.org/r/17836/#comment63614> This will state the field correctly. One other outstanding issue is stating the request type correctly. Would this fix that as well? - Neha Narkhede On Feb. 7, 2014, 4:23 a.m., Jay Kreps wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17836/ > ----------------------------------------------------------- > > (Updated Feb. 7, 2014, 4:23 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1241 > https://issues.apache.org/jira/browse/KAFKA-1241 > > > Repository: kafka > > > Description > ------- > > KAFKA-1241 Better error message for underflow on read of struct. > > > Diffs > ----- > > clients/src/main/java/org/apache/kafka/common/protocol/types/Schema.java > 0c11a04e121904b32673b0a86739e02f03066483 > clients/src/main/java/org/apache/kafka/common/protocol/types/Type.java > 24ac060a82767f913dc926ccfe99d83a596e8cf3 > > Diff: https://reviews.apache.org/r/17836/diff/ > > > Testing > ------- > > > Thanks, > > Jay Kreps > >
