Re: Review Request 17524: Add one integration test for the new producer

> On Jan. 30, 2014, 5:02 p.m., Jay Kreps wrote: > > This is a very nice test! It would be good to also have a scenario that has > > two servers with a replication-factor two topic and kills one of the > > servers to validate the reconnect/metadata logic. Yeah I plan to have the replication sce

Re: Review Request 17524: Add one integration test for the new producer

> On Jan. 30, 2014, 6:12 p.m., Jun Rao wrote: > > Could you build a release tar and make sure that we don't drag in the new > > client jar as a dependency? ./sbt release-tar failed due to ambiguous references: [error] it is imported twice in the same scope by [error] import kafka.common._ [err

Re: Review Request 17524: Add one integration test for the new producer

> On Jan. 30, 2014, 6:12 p.m., Jun Rao wrote: > > core/src/test/scala/integration/kafka/api/ProducerSendTest.scala, lines > > 75-76 > > > > > > Do we really want to print those out in an integration test? I used this

Re: Review Request 17524: Add one integration test for the new producer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17524/#review33232 --- Could you build a release tar and make sure that we don't drag in th

Re: Review Request 17524: Add one integration test for the new producer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17524/#review33225 --- Ship it! This is a very nice test! It would be good to also have a

Review Request 17524: Add one integration test for the new producer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17524/ --- Review request for kafka. Bugs: KAFKA-1233 https://issues.apache.org/jira/b