----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17524/#review33225 -----------------------------------------------------------
Ship it! This is a very nice test! It would be good to also have a scenario that has two servers with a replication-factor two topic and kills one of the servers to validate the reconnect/metadata logic. core/src/test/scala/integration/kafka/api/ProducerSendTest.scala <https://reviews.apache.org/r/17524/#comment62584> Might as well bump this up to 1000 since the test time will be dominated by setup/teardown (I suspect) and this will allow a few batched requests to be accumulated which is a little more aggressive. project/Build.scala <https://reviews.apache.org/r/17524/#comment62585> I just want to double check that you validated this doesn't cause the jar to show up in the release and won't impact the maven deps if we do a release... - Jay Kreps On Jan. 30, 2014, 2:24 a.m., Guozhang Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17524/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2014, 2:24 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1233 > https://issues.apache.org/jira/browse/KAFKA-1233 > > > Repository: kafka > > > Description > ------- > > KAFKA-1233.v1 > > > Diffs > ----- > > core/src/test/scala/integration/kafka/api/ProducerSendTest.scala > PRE-CREATION > project/Build.scala ddcfc4176e68933377590e095c07283083249f4a > > Diff: https://reviews.apache.org/r/17524/diff/ > > > Testing > ------- > > > Thanks, > > Guozhang Wang > >
