Re: Review Request 17479: Patch for KAFKA-1232

2014-02-12 Thread Jun Rao
> On Feb. 3, 2014, 7:57 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/admin/TopicCommand.scala, line 275 > > > > > > shouldn't the first check be that exactly one of alter, create, delete, > > describe or

Re: Review Request 17479: Patch for KAFKA-1232

2014-02-03 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17479/#review33484 --- core/src/main/scala/kafka/admin/TopicCommand.scala

Re: Review Request 17479: Patch for KAFKA-1232

2014-02-02 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17479/#review33404 --- Ship it! Ship It! - Guozhang Wang On Feb. 2, 2014, 7:24 p.m., Ju

Re: Review Request 17479: Patch for KAFKA-1232

2014-02-02 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17479/ --- (Updated Feb. 2, 2014, 7:24 p.m.) Review request for kafka. Bugs: KAFKA-1232

Re: Review Request 17479: Patch for KAFKA-1232

2014-01-31 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17479/#review8 --- Ship it! Ship It! - Guozhang Wang On Jan. 30, 2014, 5:51 p.m., J

Re: Review Request 17479: Patch for KAFKA-1232

2014-01-30 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17479/#review33230 --- Ship it! Ship It! - Neha Narkhede On Jan. 30, 2014, 5:51 p.m., J

Re: Review Request 17479: Patch for KAFKA-1232

2014-01-30 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17479/ --- (Updated Jan. 30, 2014, 5:51 p.m.) Review request for kafka. Bugs: KAFKA-1232

Re: Review Request 17479: Patch for KAFKA-1232

2014-01-29 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17479/#review33135 --- core/src/main/scala/kafka/admin/TopicCommand.scala

Re: Review Request 17479: Patch for KAFKA-1232

2014-01-29 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17479/#review33128 --- core/src/main/scala/kafka/admin/TopicCommand.scala

Re: Review Request 17479: Patch for KAFKA-1232

2014-01-28 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17479/ --- (Updated Jan. 29, 2014, 5:21 a.m.) Review request for kafka. Summary (updated