----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17479/ -----------------------------------------------------------
(Updated Jan. 30, 2014, 5:51 p.m.) Review request for kafka. Bugs: KAFKA-1232 https://issues.apache.org/jira/browse/KAFKA-1232 Repository: kafka Description (updated) ------- Address review comments. Only support the topics-with-overrides option in describe topic to keep list topic simple. 1. Made the topic arg optional in both list topic and describe topic. If not specified, all topics will be used. 2. Made The topics-with-overrides option available in describe topic and remove the extra print out in list topic. 3. Added a check on mutually exclusive options. Diffs (updated) ----- core/src/main/scala/kafka/admin/TopicCommand.scala 842c11047cca0531fbc572fdb25523244ba2b626 core/src/main/scala/kafka/utils/CommandLineUtils.scala 5f563ca93ed5c6e4231a42331619ca41375844ca Diff: https://reviews.apache.org/r/17479/diff/ Testing ------- Thanks, Jun Rao