Re: Review Request 16356: Patch for KAFKA-1139

2013-12-19 Thread Neha Narkhede
> On Dec. 18, 2013, 9:57 p.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/admin/TopicCommand.scala, line 75 > > > > > > We need to check if the value is a single topic string here. Guozhang, thanks for pointing

Re: Review Request 16356: Patch for KAFKA-1139

2013-12-19 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16356/#review30702 --- Ship it! Ship It! - Jun Rao On Dec. 18, 2013, 9:33 p.m., Neha Na

Re: Review Request 16356: Patch for KAFKA-1139

2013-12-18 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16356/#review30648 --- Ship it! core/src/main/scala/kafka/admin/TopicCommand.scala

Review Request 16356: Patch for KAFKA-1139

2013-12-18 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16356/ --- Review request for kafka. Bugs: KAFKA-1139 https://issues.apache.org/jira/b