----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16356/#review30648 -----------------------------------------------------------
Ship it! core/src/main/scala/kafka/admin/TopicCommand.scala <https://reviews.apache.org/r/16356/#comment58738> We need to check if the value is a single topic string here. - Guozhang Wang On Dec. 18, 2013, 9:33 p.m., Neha Narkhede wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16356/ > ----------------------------------------------------------- > > (Updated Dec. 18, 2013, 9:33 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1139 > https://issues.apache.org/jira/browse/KAFKA-1139 > > > Repository: kafka > > > Description > ------- > > Changes include 1) Added the ability to accept regular expressions on the > --topic option for the topic tool. That eased testing for this feature and is > useful in general for changing topic configs in bulk 2) Changed the topic > listener on the consumer to queue up the rebalance event instead of > explicitly invoking a rebalance > > > Diffs > ----- > > core/src/main/scala/kafka/admin/TopicCommand.scala > d25aae3cc029b530cc589d4147499a9586dc6e7d > core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala > 0cc236af2852446e2d6e84956c34370fb4a2a166 > > Diff: https://reviews.apache.org/r/16356/diff/ > > > Testing > ------- > > > Thanks, > > Neha Narkhede > >
