Re: Review Request 16175: Patch for KAFKA-1178

2013-12-11 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16175/ --- (Updated Dec. 11, 2013, 7:09 p.m.) Review request for kafka. Bugs: KAFKA-1178

Re: Review Request 16175: Patch for KAFKA-1178

2013-12-11 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16175/#review30214 --- Ship it! Looks good. I would be good to expand the comments before

Re: Review Request 16175: Patch for KAFKA-1178

2013-12-11 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16175/ --- (Updated Dec. 11, 2013, 6:30 p.m.) Review request for kafka. Bugs: KAFKA-1178

Re: Review Request 16175: Patch for KAFKA-1178

2013-12-11 Thread Neha Narkhede
> On Dec. 11, 2013, 5:48 p.m., Jun Rao wrote: > > Thanks for the patch. > > > > 1. In Controller.updateLeaderEpochAndSendRequest(), the following comment > > seems not accurate. Could we fix it? > > // send the shrunk assigned replica list to all the replicas, > > including the leader,

Re: Review Request 16175: Patch for KAFKA-1178

2013-12-11 Thread Neha Narkhede
> On Dec. 11, 2013, 5:08 p.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/server/ReplicaManager.scala, line 237 > > > > > > Under which condition the broker will not be in the assigned replica > > list? Since

Re: Review Request 16175: Patch for KAFKA-1178

2013-12-11 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16175/#review30204 --- Thanks for the patch. 1. In Controller.updateLeaderEpochAndSendRequ

Re: Review Request 16175: Patch for KAFKA-1178

2013-12-11 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16175/#review30202 --- core/src/main/scala/kafka/server/ReplicaManager.scala

Review Request 16175: Patch for KAFKA-1178

2013-12-10 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16175/ --- Review request for kafka. Bugs: KAFKA-1178 https://issues.apache.org/jira/b