> On Dec. 11, 2013, 5:48 p.m., Jun Rao wrote: > > Thanks for the patch. > > > > 1. In Controller.updateLeaderEpochAndSendRequest(), the following comment > > seems not accurate. Could we fix it? > > // send the shrunk assigned replica list to all the replicas, > > including the leader, so that it no longer > > // allows old replicas to enter ISR > > > > 2. Just a question, in Controller.onPartitionReassignment(), after calling > > updateAssignedReplicasForPartition(), we need to send LeaderAndIsr requests > > to propagate the new assigned replica list to the brokers, right? Where > > does this happen? Couldn't seem to find it in the code. > > > > 3. In Controller.onPartitionReassignment(), under "case false", it seems > > that we can update the assigned replicas and leader/isr path in ZK > > unnecessarily since this method will be called every time ISR changes.
1. fixed 2. It is sent in updateLeaderEpochAndSendRequest() 3. Not really. It is only invoked if all reassigned replicas have caught up - Neha ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16175/#review30204 ----------------------------------------------------------- On Dec. 11, 2013, 6:30 a.m., Neha Narkhede wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16175/ > ----------------------------------------------------------- > > (Updated Dec. 11, 2013, 6:30 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1178 > https://issues.apache.org/jira/browse/KAFKA-1178 > > > Repository: kafka > > > Description > ------- > > 1. Fixed broker to only follow become-follower/leader request if the broker > exists in the assigned replica list 2. Changed the under replicated check to > compare in sync replica set size with assigned replica set size instead of > passed in replication factor 3. Fixed the fetcher id computation to not > create more fetcher threads than necessary due to the negative (overflown) > hashcode value. 4. Fixed some more state change logging 5. Tested partition > reassignment several times on a cluster with several 100s of topics, verified > reassignment completion followed by no under replicated partitions (through > jmx and through zookeeper) > > > Diffs > ----- > > core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala > 65c04edc11a1eb2771bfd741d59886b5fef9ccbc > core/src/main/scala/kafka/cluster/Partition.scala > 13f48baa1bc44533c33153fde6f1c03a067d83bc > core/src/main/scala/kafka/server/AbstractFetcherManager.scala > 394e981c858fa53a28d3c7fcef0afbd4faf07858 > core/src/main/scala/kafka/server/ReplicaManager.scala > b0a39622ab91e209f9657231917a5ae30fd835f0 > > Diff: https://reviews.apache.org/r/16175/diff/ > > > Testing > ------- > > > Thanks, > > Neha Narkhede > >
