Re: Review Request 16092: Patch for KAFKA-1147

2014-09-14 Thread Neha Narkhede
> On Dec. 10, 2013, 4:14 p.m., Jun Rao wrote: > > It seems that in the consumer, we have a separate request timeout and > > socket timeout. The producer only has a request timeout now. Perhaps we > > should add the socket timeout in the producer too? > > Guozhang Wang wrote: > Currently re

Re: Review Request 16092: Patch for KAFKA-1147

2013-12-10 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16092/ --- (Updated Dec. 10, 2013, 10:31 p.m.) Review request for kafka. Bugs: KAFKA-114

Re: Review Request 16092: Patch for KAFKA-1147

2013-12-10 Thread Guozhang Wang
> On Dec. 10, 2013, 4:14 p.m., Jun Rao wrote: > > It seems that in the consumer, we have a separate request timeout and > > socket timeout. The producer only has a request timeout now. Perhaps we > > should add the socket timeout in the producer too? Currently request.timeout.ms of producer co

Re: Review Request 16092: Patch for KAFKA-1147

2013-12-10 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16092/#review30101 --- It seems that in the consumer, we have a separate request timeout an

Re: Review Request 16092: Patch for KAFKA-1147

2013-12-09 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16092/ --- (Updated Dec. 9, 2013, 5:14 p.m.) Review request for kafka. Bugs: KAFKA-1147

Re: Review Request 16092: Patch for KAFKA-1147

2013-12-09 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16092/#review30019 --- core/src/main/scala/kafka/consumer/ConsumerConfig.scala

Re: Review Request 16092: Patch for KAFKA-1147

2013-12-07 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16092/ --- (Updated Dec. 8, 2013, 2:22 a.m.) Review request for kafka. Bugs: KAFKA-1147

Re: Review Request 16092: Patch for KAFKA-1147

2013-12-06 Thread Guozhang Wang
> On Dec. 7, 2013, 5:52 a.m., Jun Rao wrote: > > core/src/main/scala/kafka/consumer/ConsumerFetcherThread.scala, lines 35-36 > > > > > > Hmm, it's probably easier to understand if sockettimeout is just > > sockettimeou

Re: Review Request 16092: Patch for KAFKA-1147

2013-12-06 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16092/#review29947 --- core/src/main/scala/kafka/consumer/ConsumerFetcherThread.scala

Re: Review Request 16092: Patch for KAFKA-1147

2013-12-06 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16092/#review29924 --- Ship it! Ship It! - Neha Narkhede On Dec. 6, 2013, 10:34 p.m., G

Review Request 16092: Patch for KAFKA-1147

2013-12-06 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16092/ --- Review request for kafka. Bugs: KAFKA-1147 https://issues.apache.org/jira/b