> On Dec. 7, 2013, 5:52 a.m., Jun Rao wrote: > > core/src/main/scala/kafka/consumer/ConsumerFetcherThread.scala, lines 35-36 > > <https://reviews.apache.org/r/16092/diff/1/?file=395201#file395201line35> > > > > Hmm, it's probably easier to understand if sockettimeout is just > > sockettimeout. So, we probably should just change the description in > > ConsumerConfig and make sure that in the config socketTimeoutMs is >= > > fetchWiaMaxMs.
I agree. Let's do that instead. - Guozhang ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16092/#review29947 ----------------------------------------------------------- On Dec. 6, 2013, 10:34 p.m., Guozhang Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16092/ > ----------------------------------------------------------- > > (Updated Dec. 6, 2013, 10:34 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1147 > https://issues.apache.org/jira/browse/KAFKA-1147 > > > Repository: kafka > > > Description > ------- > > KAFKA-1147.v1 > > > Diffs > ----- > > core/src/main/scala/kafka/consumer/ConsumerFetcherThread.scala > f8c1b4e674f7515c377c6c30d212130f1ff022dd > core/src/main/scala/kafka/server/ReplicaFetcherThread.scala > 715845b167c44268bd7e4b76dfb69199bfb2fad4 > > Diff: https://reviews.apache.org/r/16092/diff/ > > > Testing > ------- > > > Thanks, > > Guozhang Wang > >
